Ensure correct aggregation of min/max event value metrics

matomo-org · Jul 2, 2024 · 9b95430 · 9b95430
1 parent 066339f
commit 9b95430
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/plugins/Events/API.php b/plugins/Events/API.php
@@ -10,6 +10,7 @@
 namespace Piwik\Plugins\Events;
 
 use Piwik\Archive;
+use Piwik\DataTable;
 use Piwik\Piwik;
 
 /**
@@ -166,6 +167,12 @@ protected function getDataTable($name, $idSite, $period, $date, $segment, $expan
             }));
         }
 
+        $dataTable->filter(function ($dataTable) {
+            $dataTable->setMetadata(DataTable::COLUMN_AGGREGATION_OPS_METADATA_NAME, [
+                'max_event_value' => 'max',
+                'min_event_value' => 'min',
+            ]);
+        });
         $dataTable->filter('Piwik\Plugins\Events\DataTable\Filter\ReplaceEventNameNotSet');
 
         return $dataTable;

diff --git a/...ystem/expected/test_CustomEvents_Events.getCategory_lastN__API.getProcessedReport_day.xml b/...ystem/expected/test_CustomEvents_Events.getCategory_lastN__API.getProcessedReport_day.xml
@@ -181,7 +181,7 @@
 		<nb_events>69</nb_events>
 		<nb_events_with_value>14</nb_events_with_value>
 		<sum_event_value>137.96</sum_event_value>
-		<min_event_value>28.32</min_event_value>
-		<max_event_value>52.32</max_event_value>
+		<min_event_value>0</min_event_value>
+		<max_event_value>23</max_event_value>
 	</reportTotal>
 </result>