Skip to content

Commit

Permalink
ensure same column ordering as before
Browse files Browse the repository at this point in the history
  • Loading branch information
diosmosis committed Jun 28, 2023
1 parent 776e269 commit a565ea3
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 2 deletions.
14 changes: 13 additions & 1 deletion plugins/VisitTime/RecordBuilders/LocalTime.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
use Piwik\ArchiveProcessor\Record;
use Piwik\DataTable;
use Piwik\DataTable\Filter\Sort;
use Piwik\Metrics;
use Piwik\Plugins\VisitTime\Archiver;

class LocalTime extends Base
Expand All @@ -32,7 +33,18 @@ protected function aggregate(ArchiveProcessor $archiveProcessor): array

$query = $logAggregator->queryVisitsByDimension(["label" => "HOUR(log_visit.visitor_localtime)"]);
while ($row = $query->fetch()) {
$record->sumRowWithLabel($row['label'], $row);
$columns = [
Metrics::INDEX_NB_UNIQ_VISITORS => $row[Metrics::INDEX_NB_UNIQ_VISITORS],
Metrics::INDEX_NB_VISITS => $row[Metrics::INDEX_NB_VISITS],
Metrics::INDEX_NB_ACTIONS => $row[Metrics::INDEX_NB_ACTIONS],
Metrics::INDEX_NB_USERS => $row[Metrics::INDEX_NB_USERS],
Metrics::INDEX_MAX_ACTIONS => $row[Metrics::INDEX_MAX_ACTIONS],
Metrics::INDEX_SUM_VISIT_LENGTH => $row[Metrics::INDEX_SUM_VISIT_LENGTH],
Metrics::INDEX_BOUNCE_COUNT => $row[Metrics::INDEX_BOUNCE_COUNT],
Metrics::INDEX_NB_VISITS_CONVERTED => $row[Metrics::INDEX_NB_VISITS_CONVERTED],
];

$record->sumRowWithLabel($row['label'], $columns);
}

$this->ensureAllHoursAreSet($record);
Expand Down
14 changes: 13 additions & 1 deletion plugins/VisitTime/RecordBuilders/ServerTime.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,19 @@ protected function aggregate(ArchiveProcessor $archiveProcessor): array
$query = $logAggregator->queryVisitsByDimension(["label" => "HOUR(log_visit.visit_first_action_time)"]);
while ($row = $query->fetch()) {
$row['label'] = $this->convertTimeToLocalTimezone($row['label'], $archiveProcessor);
$record->sumRowWithLabel($row['label'], $row);

$columns = [
Metrics::INDEX_NB_UNIQ_VISITORS => $row[Metrics::INDEX_NB_UNIQ_VISITORS],
Metrics::INDEX_NB_VISITS => $row[Metrics::INDEX_NB_VISITS],
Metrics::INDEX_NB_ACTIONS => $row[Metrics::INDEX_NB_ACTIONS],
Metrics::INDEX_NB_USERS => $row[Metrics::INDEX_NB_USERS],
Metrics::INDEX_MAX_ACTIONS => $row[Metrics::INDEX_MAX_ACTIONS],
Metrics::INDEX_SUM_VISIT_LENGTH => $row[Metrics::INDEX_SUM_VISIT_LENGTH],
Metrics::INDEX_BOUNCE_COUNT => $row[Metrics::INDEX_BOUNCE_COUNT],
Metrics::INDEX_NB_VISITS_CONVERTED => $row[Metrics::INDEX_NB_VISITS_CONVERTED],
];

$record->sumRowWithLabel($row['label'], $columns);
}

$query = $logAggregator->queryConversionsByDimension(["label" => "HOUR(log_conversion.server_time)"]);
Expand Down

0 comments on commit a565ea3

Please sign in to comment.