improve/update UI tests

matomo-org · Nov 29, 2023 · b3e6d3e · b3e6d3e
1 parent 95f1013
commit b3e6d3e
Show file tree

Hide file tree

Showing 24 changed files with 56 additions and 46 deletions.
diff --git a/...ns/CoreAdminHome/tests/UI/expected-screenshots/MobileMenu_mobileMenuPartial.png b/...ns/CoreAdminHome/tests/UI/expected-screenshots/MobileMenu_mobileMenuPartial.png
diff --git a/...s/CoreAdminHome/tests/UI/expected-screenshots/TrackingCodeGenerator_initial.png b/...s/CoreAdminHome/tests/UI/expected-screenshots/TrackingCodeGenerator_initial.png
diff --git a/plugins/Morpheus/tests/UI/expected-screenshots/Morpheus_load.png b/plugins/Morpheus/tests/UI/expected-screenshots/Morpheus_load.png
diff --git a/plugins/PrivacyManager/tests/UI/PrivacyManager_ConsentManager_spec.js b/plugins/PrivacyManager/tests/UI/PrivacyManager_ConsentManager_spec.js
@@ -31,7 +31,9 @@ describe("PrivacyManager_ConsentManager", function () {
     it('should load privacy asking for consent page', async function() {
         await page.goto(urlBase + 'consent');
         await page.waitForNetworkIdle();
-      expect(await page.screenshotSelector('.pageWrap,#notificationContainer,.modal.open')).to.matchImage('consent_default');
+        await page.evaluate(function () {
+            $('#secondNavBar').css('visibility', 'hidden'); // hide navbar so shadow isn't shown on screenshot
+        });
+        expect(await page.screenshotSelector('.pageWrap,#notificationContainer,.modal.open')).to.matchImage('consent_default');
     });
-
 });
diff --git a/plugins/PrivacyManager/tests/UI/PrivacyManager_spec.js b/plugins/PrivacyManager/tests/UI/PrivacyManager_spec.js
@@ -118,7 +118,15 @@ describe("PrivacyManager", function () {
 
     async function capturePage(screenshotName) {
         await page.waitForNetworkIdle();
-        expect(await page.screenshotSelector('.pageWrap,#notificationContainer,.modal.open')).to.matchImage(screenshotName);
+        await page.evaluate(function () {
+            $('#secondNavBar').css('visibility', 'hidden'); // hide navbar so shadow isn't shown on screenshot
+        });
+        const pageWrap = await page.$('.pageWrap,#notificationContainer,.modal.open');
+        const screenshot = await pageWrap.screenshot();
+        await page.evaluate(function () {
+            $('#secondNavBar').css('visibility', 'visible'); // show navbar again
+        });
+        expect(screenshot).to.matchImage(screenshotName);
     }
 
     async function captureAnonymizeLogData(screenshotName) {

diff --git a/...tests/UI/expected-screenshots/PrivacyManager_ConsentManager_consent_default.png b/...tests/UI/expected-screenshots/PrivacyManager_ConsentManager_consent_default.png
diff --git a/...PrivacyManager/tests/UI/expected-screenshots/PrivacyManager_consent_default.png b/...PrivacyManager/tests/UI/expected-screenshots/PrivacyManager_consent_default.png
diff --git a/...s/PrivacyManager/tests/UI/expected-screenshots/PrivacyManager_gdpr_overview.png b/...s/PrivacyManager/tests/UI/expected-screenshots/PrivacyManager_gdpr_overview.png
diff --git a/...ger/tests/UI/expected-screenshots/PrivacyManager_gdpr_overview_no_retention.png b/...ger/tests/UI/expected-screenshots/PrivacyManager_gdpr_overview_no_retention.png
diff --git a/...vacyManager/tests/UI/expected-screenshots/PrivacyManager_gdpr_tools_default.png b/...vacyManager/tests/UI/expected-screenshots/PrivacyManager_gdpr_tools_default.png
diff --git a/...ts/UI/expected-screenshots/PrivacyManager_gdpr_tools_delete_visit_cancelled.png b/...ts/UI/expected-screenshots/PrivacyManager_gdpr_tools_delete_visit_cancelled.png
diff --git a/...s/PrivacyManager_gdpr_tools_delete_visit_cancelled_verified_no_data_deleted.png b/...s/PrivacyManager_gdpr_tools_delete_visit_cancelled_verified_no_data_deleted.png
diff --git a/...ts/UI/expected-screenshots/PrivacyManager_gdpr_tools_delete_visit_confirmed.png b/...ts/UI/expected-screenshots/PrivacyManager_gdpr_tools_delete_visit_confirmed.png
diff --git a/...ests/UI/expected-screenshots/PrivacyManager_gdpr_tools_enrich_segment_by_ip.png b/...ests/UI/expected-screenshots/PrivacyManager_gdpr_tools_enrich_segment_by_ip.png
diff --git a/...ger/tests/UI/expected-screenshots/PrivacyManager_gdpr_tools_no_visits_found.png b/...ger/tests/UI/expected-screenshots/PrivacyManager_gdpr_tools_no_visits_found.png
diff --git a/...r/tests/UI/expected-screenshots/PrivacyManager_gdpr_tools_uncheck_one_visit.png b/...r/tests/UI/expected-screenshots/PrivacyManager_gdpr_tools_uncheck_one_visit.png
diff --git a/...anager/tests/UI/expected-screenshots/PrivacyManager_gdpr_tools_visits_found.png b/...anager/tests/UI/expected-screenshots/PrivacyManager_gdpr_tools_visits_found.png
diff --git a/...nager/tests/UI/expected-screenshots/PrivacyManager_privacy_settings_default.png b/...nager/tests/UI/expected-screenshots/PrivacyManager_privacy_settings_default.png
diff --git a/...yManager/tests/UI/expected-screenshots/PrivacyManager_users_opt_out_default.png b/...yManager/tests/UI/expected-screenshots/PrivacyManager_users_opt_out_default.png
diff --git a/plugins/UsersManager/tests/UI/expected-screenshots/UserSettings_signup_success.png b/plugins/UsersManager/tests/UI/expected-screenshots/UserSettings_signup_success.png
diff --git a/tests/UI/expected-screenshots/Menus_admin_changed.png b/tests/UI/expected-screenshots/Menus_admin_changed.png
diff --git a/tests/UI/expected-screenshots/Menus_admin_loaded.png b/tests/UI/expected-screenshots/Menus_admin_loaded.png
diff --git a/tests/UI/expected-screenshots/Menus_admin_websites.png b/tests/UI/expected-screenshots/Menus_admin_websites.png
diff --git a/tests/UI/expected-screenshots/Theme_demo.png b/tests/UI/expected-screenshots/Theme_demo.png