Expose goal sum metrics added to reports via EnrichRecordWithGoalMetr…

…icSums to report metadata.
matomo-org · Jun 1, 2024 · d5f969c · d5f969c
1 parent 25cffc3
commit d5f969c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/plugins/Goals/Goals.php b/plugins/Goals/Goals.php
@@ -359,6 +359,9 @@ public function getReportMetadataEnd(&$reports, $info)
 
         $reportsWithGoals = self::getAllReportsWithGoalMetrics();
 
+        $conversionDocsTranslation = Piwik::translate('Goals_ColumnConversionSumDocumentation');
+        $revenueDocsTranslation = Piwik::translate('Goals_ColumnRevenueSumDocumentation');
+
         foreach ($reportsWithGoals as $reportWithGoals) {
             $goalMetricsToUse = $goalMetrics;
             $goalProcessedMetricsToUse = $goalProcessedMetrics;
@@ -383,6 +386,16 @@ public function getReportMetadataEnd(&$reports, $info)
                     && $apiReportToUpdate['action'] == $reportWithGoals['action']
                     && empty($apiReportToUpdate['parameters'])
                 ) {
+                    // add overall Goal metrics computed during archiving by EnrichRecordWithGoalMetricSums
+                    $apiReportToUpdate['metrics']['nb_conversions'] = $goalMetrics['nb_conversions'];
+                    $apiReportToUpdate['metrics']['revenue'] = $goalMetrics['revenue'];
+
+                    $apiReportToUpdate['metricsDocumentation']['nb_conversions'] = $conversionDocsTranslation;
+                    $apiReportToUpdate['metricsDocumentation']['revenue'] = $revenueDocsTranslation;
+
+                    $apiReportToUpdate['metricTypes']['nb_conversions'] = Dimension::TYPE_NUMBER;
+                    $apiReportToUpdate['metricTypes']['revenue'] = Dimension::TYPE_MONEY;
+
                     $apiReportToUpdate['metricsGoal'] = $goalMetricsToUse;
                     $apiReportToUpdate['processedMetricsGoal'] = $goalProcessedMetricsToUse;
                     $apiReportToUpdate['metricTypesGoal'] = $goalMetricTypesToUse;

diff --git a/plugins/Goals/lang/en.json b/plugins/Goals/lang/en.json
@@ -29,10 +29,12 @@
         "ColumnConversions": "Conversions",
         "Conversion": "Conversion",
         "ColumnConversionsDocumentation": "The number of conversions for %s.",
+        "ColumnConversionSumDocumentation": "The total number of conversions for all goals.",
         "ColumnOrdersDocumentation": "The total number of Ecommerce orders which contained this %s at least once.",
         "ColumnPurchasedProductsDocumentation": "The number of purchased products is the sum of Product quantities sold in all Ecommerce orders.",
         "ColumnQuantityDocumentation": "Quantity is the total number of products sold for each %s.",
         "ColumnRevenueDocumentation": "The total revenue generated by %s.",
+        "ColumnRevenueSumDocumentation": "The total revenue generated for all goals.",
         "ColumnRevenuePerVisitDocumentation": "The total revenue generated by %s divided by the number of visits.",
         "ColumnRevenuePerEntryDocumentation": "The total revenue generated by %s divided by the number of entrances.",
         "ColumnVisits": "The total number of visits, regardless of whether a goal was triggered or not.",