Add support for up to 4 fields to multipairfield #15125
Conversation
|
Looks good in general @MichaelHeerklotz but haven't tested it yet. Could you maybe add an example to |
|
@tsteur Thank you for your feedback! I have fixed/updated the styles a bit and updated the demo template. |
| var self = this; | ||
| $scope.$watch('formValue', function () { | ||
| $scope.$watch('formValue', function () {; |
There was a problem hiding this comment.
The semicolon might be there by accident?
There was a problem hiding this comment.
| $scope.$watch('formValue', function () {; | |
| $scope.$watch('formValue', function () { |
|
Change looks good 👍 any chance you could include this UI change https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/36950/Morpheus_load.png ? (screenshot update looks expected) |
|
@tsteur guess we won't merge that in the last 3.x release, right? Could update the base branch otherwise, merge into 4.x-dev and update the screenshot afterwards... |
|
Yes, Matomo 4 👍 |
sgiehl
changed the base branch from
4.x-dev
to
multipairfield_4_field_support
|
I'll merge this into a local branch and recreate the PR with updated tests |
mattab
added
the
c: Platform
Adds support for up to 4 fields in the multipairfield config template.
Needed for another pull requests for Tag Manager (support for Custom Variables matomo-org/tag-manager#201).
Maybe the changes in "plugins/CorePluginsAdmin/angularjs/form-field/field-multituple.html" are not required? I am not 100% sure.