-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use RecordBuilders in VisitTime plugin #20766
Conversation
…via RecordBuilders
…d since archiving is a recursive process
…before this change)
…rd needed is created by a RecordBuilder
…ta is present within them. if some are not present, only archive those in a new partial archive.
…rent archive request
…iver class instances will not be created
…meric archive table, otherwise blob archive table
…typo causing this to fail
…yet mark RecordBuilder as api
We might chain the PRs in the way they were done so that we only see the incremental changes. When the first one is merged the target branch would get automatically updated etc. Having all the changes from all the other PRs make this quite hard to navigate. |
@michalkleiner Please review/merge the original RecordBuilder PR first. This one does not have the Needs Review tag for a reason. |
Fair point, missed that missing tag. Sorry! |
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diosmosis there seems to be a related test failing. It works on 5.x-dev, so it seems to be connected to the changes in this PR.
@sgiehl should be fixed by latest commit. will fix the same issue for other PRs as well. |
Description:
This PR is based off of #20720 which should be reviewed and merged first.
Changes:
Review