Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodules RecordBuilder change #20767

Closed
wants to merge 2 commits into from

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented May 20, 2023

Description:

This PR depends on #20720 which should be reviewed and merged first.

As title. Includes submodule updates for every plugin submodule that includes an Archiver.

Plugin PRs:

Review

@diosmosis diosmosis added this to the 5.0.0 milestone May 20, 2023
@diosmosis diosmosis marked this pull request as draft May 30, 2023 07:02
@github-actions
Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jun 14, 2023
@diosmosis diosmosis force-pushed the update-submodules-record-builder branch from b90ecbd to 7f7a6ae Compare June 28, 2023 21:37
@michalkleiner michalkleiner removed the Stale The label used by the Close Stale Issues action label Jun 28, 2023
@diosmosis diosmosis marked this pull request as ready for review June 29, 2023 00:45
@diosmosis diosmosis added Needs Review PRs that need a code review and removed Needs Review PRs that need a code review labels Jun 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 6, 2023
@sgiehl
Copy link
Member

sgiehl commented Jul 10, 2023

Converting this one back to draft, as we won't merge it, as submodules will be updated once they were merged. But it might still be helpful to see if the record builder changes for submodules work as expected...

@sgiehl sgiehl marked this pull request as draft July 10, 2023 11:48
@github-actions github-actions bot removed the Stale The label used by the Close Stale Issues action label Jul 11, 2023
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 18, 2023
@sgiehl sgiehl removed the Needs Review PRs that need a code review label Jul 18, 2023
@github-actions
Copy link
Contributor

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale for long The label used by the Close Stale Issues action label Aug 30, 2023
@diosmosis diosmosis closed this Aug 30, 2023
@diosmosis diosmosis deleted the update-submodules-record-builder branch August 30, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale for long The label used by the Close Stale Issues action Stale The label used by the Close Stale Issues action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants