Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSS Stylelint] Disallow appending unit to zero values #20932

Merged
merged 4 commits into from
Jun 27, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 26, 2023

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jun 26, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Jun 26, 2023
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. PHPStorm complains about zero values with units by default, so it's consistent to have it as a lint rule too 👍

Base automatically changed from stylelint_rule_no-irregular-whitespace to 5.x-dev June 27, 2023 05:05
@sgiehl sgiehl merged commit a3b1d03 into 5.x-dev Jun 27, 2023
10 of 20 checks passed
@sgiehl sgiehl deleted the styleline_rule_legnth-zero-no-unit branch June 27, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants