Make links underlined everywhere #20940
Conversation
sgiehl
added
c: Design / UI
sgiehl
force-pushed
the
linkstyles
branch
7 times, most recently
from
9ae1d61
to
b9e50c2
Compare
|
@bx80 @michalkleiner If you have some time, feel free to already have a look at that one. I hop all links should be underlined by now, but I'm still looking a bit through the changed screenshots to check if I see a link that might still not be underlined. If you spot anything that still needs to be adjusted, let me know. |
| @@ -262,7 +262,7 @@ public function configureView(ViewDataTable $view) | |||
| }; | |||
| } | |||
| } elseif ($view->isViewDataTableId(Evolution::ID)) { | |||
| if (!empty($idSite) && Piwik::isUserHasWriteAccess($idSite)) { | |||
| if (!empty($idSite) && Piwik::isUserHasWriteAccess($idSite) && $idGoal > GoalManager::IDGOAL_ORDER) { | |||
There was a problem hiding this comment.
This fixes a "bug", where the ecommerce goal title was clickable, referring to an invalid page, as the ecommerce goal isn't editable.
sgiehl
force-pushed
the
linkstyles
branch
3 times, most recently
from
0d82e3b
to
d0593df
Compare
| color: @theme-color-text; | ||
| white-space: nowrap; |
There was a problem hiding this comment.
This is actually a small improvement so that the link content › more isn't split onto two lines.
sgiehl
force-pushed
the
linkstyles
branch
2 times, most recently
from
7d20eba
to
18f47f4
Compare
There was a problem hiding this comment.
I've looked through every config and dashboard page in the UI and it generally all look really good.
The only things I noticed:
<a> buttons without the btn class shown an underline on hover, whereas <a> buttons with the btn class do not. For example Admin > Personal > Security 'Create new Token' vs 'Turn on two-factor authentication'. Changing .tableActionBar a &:hover to text-decorated: none seemed to resolve this but I'm not sure if this is used elsewhere for non-buttons?
The site selector and period selector buttons don't underline on hover as expected, but the check for update button does, it seems to be the span not the button that has the underline.
The Admin > Measurables > MTM panel bottom links have the icons underlined along with the link. This is quite a minor thing, so feel free to ignore 🙂
|
@bx80 All of those misplaced underlines where actually already the case before this PR, but I'll try to push some fixes. |
sgiehl
force-pushed
the
linkstyles
branch
3 times, most recently
from
5ac777c
to
3eaabf7
Compare
|
Everything should be updated now. |
|
I'll have a quick look today as well |
|
We shouldn't be underlying the space between the icon and the text of the link, it should use margin-right to create the space.
|
sgiehl
added
not-in-changelog
Description:
fixes #20706
Review