Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the font cache buster parameter #20971

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented Jul 6, 2023

Description:

Recent changes have added new glyphs to the Matomo icon font, this PR updates the cache buster parameter in the icons stylesheet to invalidate any browser font caching and make sure the updated font is used.

This is the 4.x version of #20945

Review

@bx80 bx80 self-assigned this Jul 6, 2023
@bx80 bx80 added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jul 6, 2023
@bx80 bx80 added this to the 4.15.0 milestone Jul 6, 2023
@bx80 bx80 added the Needs Review PRs that need a code review label Jul 6, 2023
@michalkleiner
Copy link
Contributor

michalkleiner commented Jul 6, 2023

Should we use a different cb to make sure 4.x and 5.x are different? Not sure there are any content differences but it feels safer for no extra cost.

@bx80
Copy link
Contributor Author

bx80 commented Jul 6, 2023

Yes, that's a good point, I think the font is the same between 4.x-dev and 5.x-dev, but probably safer to keep it unique 👍

@sgiehl sgiehl merged commit 5515b77 into 4.x-dev Jul 6, 2023
16 of 21 checks passed
@sgiehl sgiehl deleted the update-font-cachebuster4 branch July 6, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants