Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid checking for raw data if visits log is disabled #21176

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Aug 24, 2023

Description:

When a report page has no data, we currently use Live.getLastVisitsDetails to determine if any raw data is available.
If that is the case we show a notification that explains, that data was not yet processed and that the visits log can show whats currently happening on the site.

In case the visits log is disabled, the Live.getLastVisitsDetails throws an error, which might then be displayed to the user.
As there is no sense in suggesting the user to look at the visits log if it's disabled, this PR simply disables the check for raw data in that case.

fixes #20948

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Aug 24, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Aug 24, 2023
@sgiehl sgiehl merged commit d58c2ab into 5.x-dev Aug 25, 2023
19 of 20 checks passed
@sgiehl sgiehl deleted the m20948 branch August 25, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Occasional Error message when Visitor Log is deactivate (regression)
2 participants