Implement the tracker install check for other tabs #21191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-tracker-install-check
…matomo-org/matomo into pg-2937-wordpress-tracker-install-check
snake14
merged commit c7c719e
into
pg-2969-js-tracker-install-check
15 of 20 checks passed
sgiehl
added a commit
that referenced
this pull request
Sep 6, 2023
* Create new Vue component for testing tracking code installation * Making correction for PPHCS * Adding a forceful close of the new tab if the tracking code fails to load * Updating expected results * Adding plugin.json file for plugin description * Cleaning up template code a little more * Updating screenshot * Adding some integration tests * Making a couple corrections * Adding some more integration tests * Moved the Vue component outof CoreHome * Update plugins/JsTrackerInstallCheck/tests/Integration/APITest.php with suggested change. Co-authored-by: Stefan Giehl <[email protected]> * Update plugins/JsTrackerInstallCheck/JsTrackerInstallCheck.php with suggested change. Co-authored-by: Stefan Giehl <[email protected]> * Making changes recommended during code review * Making a couple adjustments * Adding more test cases * Trying to get rid of JSLint errors * Fixing PHPCS issue * Removing plugin.json file * Update js/piwik.js Co-authored-by: Stefan Giehl <[email protected]> * Making some recommended changes * Updating view template after recent API changes * Adding migration to make sure that the new plugin is enabled * Adding some more test cases * Making slight wording change * Re-minifying JS * Updating a couple screenshots * Making a couple recommended changes * Implement the tracker install check for other tabs (#21191) * Start working on WordPress test implementation * Slight wording change * Updating component to allow passing in a specific URL * Adding new test case * Working on new JSON format for the option * Further refining new JSON format changes * Cleaning up tests a bit more * Adding new install test section to the JS Tracking Code tab * Making a couple minor adjustments * Cleaing up the templates a little more * Fixing PHPCS errors * Updating order of no data tabs * Build Vue files * Fixing some issues * Updating more screenshots * Adding a couple more waits to the UI tests * Adding the automatic close on test to other request send methods * Removing a couple debug statements * Fixing some JSLint and styling issues * Cleaning up a component import * Removing an unused file and updating a couple other files * Fixing a UI issue and adjusting some tests * update expected ui files * Fixing new translation to use ellipsis * Updating wording to help avoid confusion * Updating some test cases and screenshots * Updating more screenshots * Updating another test case * Adding wait to test case * disable auto sanitizing for API and add param validation * use valid nonce for testing * clean up tests * clean up js * fix api check * updates expected screenshot * improve html structure and clean up vue code * fix html structure * Make tracking code pages work when plugin is disabled * fix typo Co-authored-by: Michal Kleiner <[email protected]> * improve wording Co-authored-by: Michal Kleiner <[email protected]> * updates expected UI test files --------- Co-authored-by: Ben Burgess <[email protected]> Co-authored-by: Stefan Giehl <[email protected]> Co-authored-by: Michal Kleiner <[email protected]>
sgiehl
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Implement the tracker install check for other tabs
Review