Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the tracker install check for other tabs #21191

Merged

Conversation

snake14
Copy link
Contributor

@snake14 snake14 commented Aug 28, 2023

Description:

Implement the tracker install check for other tabs

Review

@snake14 snake14 merged commit c7c719e into pg-2969-js-tracker-install-check Aug 28, 2023
15 of 20 checks passed
@snake14 snake14 deleted the pg-2937-wordpress-tracker-install-check branch August 28, 2023 20:33
sgiehl added a commit that referenced this pull request Sep 6, 2023
* Create new Vue component for testing tracking code installation

* Making correction for PPHCS

* Adding a forceful close of the new tab if the tracking code fails to load

* Updating expected results

* Adding plugin.json file for plugin description

* Cleaning up template code a little more

* Updating screenshot

* Adding some integration tests

* Making a couple corrections

* Adding some more integration tests

* Moved the Vue component outof CoreHome

* Update plugins/JsTrackerInstallCheck/tests/Integration/APITest.php with suggested change.

Co-authored-by: Stefan Giehl <[email protected]>

* Update plugins/JsTrackerInstallCheck/JsTrackerInstallCheck.php with suggested change.

Co-authored-by: Stefan Giehl <[email protected]>

* Making changes recommended during code review

* Making a couple adjustments

* Adding more test cases

* Trying to get rid of JSLint errors

* Fixing PHPCS issue

* Removing plugin.json file

* Update js/piwik.js

Co-authored-by: Stefan Giehl <[email protected]>

* Making some recommended changes

* Updating view template after recent API changes

* Adding migration to make sure that the new plugin is enabled

* Adding some more test cases

* Making slight wording change

* Re-minifying JS

* Updating a couple screenshots

* Making a couple recommended changes

* Implement the tracker install check for other tabs (#21191)

* Start working on WordPress test implementation

* Slight wording change

* Updating component to allow passing in a specific URL

* Adding new test case

* Working on new JSON format for the option

* Further refining new JSON format changes

* Cleaning up tests a bit more

* Adding new install test section to the JS Tracking Code tab

* Making a couple minor adjustments

* Cleaing up the templates a little more

* Fixing PHPCS errors

* Updating order of no data tabs

* Build Vue files

* Fixing some issues

* Updating more screenshots

* Adding a couple more waits to the UI tests

* Adding the automatic close on test to other request send methods

* Removing a couple debug statements

* Fixing some JSLint and styling issues

* Cleaning up a component import

* Removing an unused file and updating a couple other files

* Fixing a UI issue and adjusting some tests

* update expected ui files

* Fixing new translation to use ellipsis

* Updating wording to help avoid confusion

* Updating some test cases and screenshots

* Updating more screenshots

* Updating another test case

* Adding wait to test case

* disable auto sanitizing for API and add param validation

* use valid nonce for testing

* clean up tests

* clean up js

* fix api check

* updates expected screenshot

* improve html structure and clean up vue code

* fix html structure

* Make tracking code pages work when plugin is disabled

* fix typo

Co-authored-by: Michal Kleiner <[email protected]>

* improve wording

Co-authored-by: Michal Kleiner <[email protected]>

* updates expected UI test files

---------

Co-authored-by: Ben Burgess <[email protected]>
Co-authored-by: Stefan Giehl <[email protected]>
Co-authored-by: Michal Kleiner <[email protected]>
@sgiehl sgiehl added this to the 5.0.0 milestone Sep 7, 2023
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants