Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move plugin related sub menu items to new Plugins menu item #21605

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 29, 2023

Description:

fixes DEV-17433

Note: Some UI tests are failing because of the menu changes. I've created separate PRs to fix them:

CustomAlerts: matomo-org/plugin-CustomAlerts#153
CustomVariables: matomo-org/plugin-CustomVariables#80
PrivacyManager: #21607
Login (Brutefoce Log): #21608
API error: #21615

Review

@sgiehl sgiehl added the c: Usability For issues that let users achieve a defined goal more effectively or efficiently. label Nov 29, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Nov 29, 2023
@sgiehl sgiehl added the Needs Review PRs that need a code review label Nov 30, 2023
@sgiehl sgiehl requested a review from a team November 30, 2023 15:42
Copy link
Contributor

@caddoo caddoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and functionally is good.
Code is fine as well.

There are some unrelated UI expected screenshots that have been updated, is that just an unrelated clean up so they pass?

@sgiehl
Copy link
Member Author

sgiehl commented Dec 1, 2023

Yes. Those are flaky tests that failed a lot with the previous versions. But they still fail sometimes with the updated files 🤷

@sgiehl sgiehl merged commit cd92626 into 5.x-dev Dec 1, 2023
23 of 26 checks passed
@sgiehl sgiehl deleted the dev-17433 branch December 1, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants