-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move plugin related sub menu items to new Plugins menu item #21605
Conversation
0424594
to
dafbe4d
Compare
8ed1424
to
55cbbb9
Compare
and add css classes for previously added ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and functionally is good.
Code is fine as well.
There are some unrelated UI expected screenshots that have been updated, is that just an unrelated clean up so they pass?
Yes. Those are flaky tests that failed a lot with the previous versions. But they still fail sometimes with the updated files 🤷 |
Description:
fixes DEV-17433
Note: Some UI tests are failing because of the menu changes. I've created separate PRs to fix them:
CustomAlerts: matomo-org/plugin-CustomAlerts#153
CustomVariables: matomo-org/plugin-CustomVariables#80
PrivacyManager: #21607
Login (Brutefoce Log): #21608
API error: #21615
Review