Skip to content

Added common command to check direct use of dependencies, #PG-3272#21969

Merged
michalkleiner merged 13 commits into5.x-devfrom
PG-3272-check-direct-dep
Mar 1, 2024
Merged

Added common command to check direct use of dependencies, #PG-3272#21969
michalkleiner merged 13 commits into5.x-devfrom
PG-3272-check-direct-dep

Conversation

@AltamashShaikh
Copy link
Copy Markdown
Contributor

Description:

Added common command to check direct use of dependencies
Fixes: #PG-3272

Review

Comment thread .github/workflows/matomo-tests.yml
Comment thread plugins/TestRunner/Commands/CheckDirectDependencyUse.php
Comment thread plugins/TestRunner/Commands/CheckDirectDependencyUse.php Outdated
@michalkleiner
Copy link
Copy Markdown
Contributor

Generally I'm happy with this, any notes/concerns from @matomo-org/core-reviewers?

@michalkleiner michalkleiner requested a review from a team February 27, 2024 06:22
@michalkleiner michalkleiner added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Stability For issues that make Matomo more stable and reliable to run for sys admins. labels Feb 27, 2024
@michalkleiner
Copy link
Copy Markdown
Contributor

Also, should this be mentioned in the changelog? I'm 50/50 on that.

@AltamashShaikh
Copy link
Copy Markdown
Contributor Author

Also, should this be mentioned in the changelog? I'm 50/50 on that.

@michalkleiner We added in TestRunner as we don't need a release for it, so I don't think we would need to mention it in changelog, if we do might be useful for other plugin developers.

@michalkleiner
Copy link
Copy Markdown
Contributor

@bx80 @caddoo any thoughts here?

Copy link
Copy Markdown
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, just a minor comment on the paramter descriptions 👍 Not sure that we need to mention the new command in the changelog as long as the developer documentation is updated.

Comment thread plugins/TestRunner/Commands/CheckDirectDependencyUse.php Outdated
@AltamashShaikh
Copy link
Copy Markdown
Contributor Author

This looks good to me, just a minor comment on the paramter descriptions 👍 Not sure that we need to mention the new command in the changelog as long as the developer documentation is updated.

@bx80 Created matomo-org/developer-documentation#778 to mention the same in developer documentation.

Can we merge this PR now ?

@michalkleiner
Copy link
Copy Markdown
Contributor

Thanks for opening the docs PR as well, @AltamashShaikh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Stability For issues that make Matomo more stable and reliable to run for sys admins.

Development

Successfully merging this pull request may close these issues.

3 participants