Expose goal sum metrics added to reports via EnrichRecordWithGoalMetricSums to report metadata. #22272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icSums to report metadata.
11 tasks
diosmosis
force-pushed
the
missing-processed-report-metrics
branch
from
5113efa
to
bce3b72
Compare
|
Not sure if this is ready for review as the label hasn't been added yet. There are some UI tests that need updating with the new metrics as well. |
…me or all goals), but not the overall goal sum metrics provided by EnrichRecordWithGoalMetricSums
diosmosis
force-pushed
the
missing-processed-report-metrics
branch
from
2067dcd
to
b4d1125
Compare
|
Should be ready for review now. |
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
github-actions
bot
added
the
Stale
diosmosis
added
the
Do not close
github-actions
bot
removed
the
Stale
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
github-actions
bot
added
Stale
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
github-actions
bot
added
Stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Refs matomo-org/looker-studio-connector#62
As title. This PR allows API consumers that depend on report metadata to use the overall
nb_conversionsandrevenuemetrics added to some reports that useEnrichRecordWithGoalMetricSumsduring archiving.Review