fixed 200 OK BUG #22334
Open
fixed 200 OK BUG #22334
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkleiner
requested changes
Jun 24, 2024
core/API/ResponseBuilder.php
Outdated
| @@ -136,7 +136,6 @@ public function getResponseException($e) | |||
| { | |||
| $e = $this->decorateExceptionWithDebugTrace($e); | |||
| $message = $this->formatExceptionMessage($e); | |||
|
|
|||
There was a problem hiding this comment.
Please reset this change (i.e. keep the empty line)
Co-authored-by: Michal Kleiner <[email protected]>
Co-authored-by: Michal Kleiner <[email protected]>
sgiehl
reviewed
Jun 28, 2024
sgiehl
reviewed
Jun 28, 2024
sgiehl
reviewed
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.
The change ensures the response created by the ResponseBuilder has a 404 status code in case a method doesn't exist.
Review