Fix aggregation of additional action metrics

[sgiehl]

Description:

Some plugins like PagePerformance or Bandwidth are adding additional metrics to the action reports. Some of those metrics need to be aggregated using min, max or avg aggregation.

As those column aggregation where not correctly set for the datatables, they were by default aggregated by summing the values up. This resulted in incorrect values.

fixes #22350

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed

[sgiehl]

This was added to handle min and max values the same. Without that all max values would always be 0, even if there was not a single value tracked.

[rr-it]

Is the actual logic behind the code as follows?

            case 'max':
                if (!is_numeric($thisColumnValue) && !is_numeric($columnToSumValue)) {
                    $newValue = null;
                } else {
                    $newValue = max(
                        (is_numeric($thisColumnValue) ? +($thisColumnValue) : -INF),
                        (is_numeric($columnToSumValue) ? +($columnToSumValue) : -INF)
                    );
                }

[rr-it]

Please also check implementation of min.

[rr-it]

The implementation of min looks like it is not providing the expected result for:

• $thisColumnValue = 0
• $columnToSumValue = null

Current result: $newValue = null

Expected result: $newValue = 0

---

This might work as expected:

            case 'min':
                if (!is_numeric($thisColumnValue) && !is_numeric($columnToSumValue)) {
                    $newValue = null;
                } else {
                    $newValue = min(
                        (is_numeric($thisColumnValue) ? +($thisColumnValue) : INF),
                        (is_numeric($columnToSumValue) ? +($columnToSumValue) : INF)
                    );
                }