Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move methods related to optimizing database tables to schema classes #22355

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 1, 2024

Description:

We have some methods that are responsible for optimizing database tables.
As support for optimizing a table depends on the database table engine as well as on the database engine itself, this PR moves the related code to the Schema classes, so we separat implementation for MySQL, MariaDb and TiDb.

refs #19655, DEV-18195

Review

@sgiehl sgiehl added this to the 5.2.0 milestone Jul 1, 2024
@sgiehl sgiehl changed the title Use methods related to optimizing database tables to schema classes Move methods related to optimizing database tables to schema classes Jul 1, 2024
@sgiehl sgiehl added c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Needs Review PRs that need a code review labels Jul 1, 2024
@sgiehl sgiehl requested a review from a team July 1, 2024 14:31
core/Db.php Show resolved Hide resolved
tests/PHPUnit/Integration/Db/Schema/TiDbTest.php Outdated Show resolved Hide resolved
@sgiehl sgiehl merged commit d712ca6 into 5.x-dev Jul 5, 2024
24 of 25 checks passed
@sgiehl sgiehl deleted the optimizetables branch July 5, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants