Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust some database statement related tests #22356

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Adjust some database statement related tests #22356

merged 1 commit into from
Jul 2, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 1, 2024

Description:

With introducing a separate schema class for TiDb and building certain queries differently based on the database engine, some tests would currently fail on TiDb. This PR adjusts some of those tests to make them pass again.

refs #19655, DEV-18198

Review

@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jul 1, 2024
@sgiehl sgiehl added this to the 5.2.0 milestone Jul 1, 2024
@sgiehl sgiehl requested a review from a team July 1, 2024 16:13
@sgiehl sgiehl added the Needs Review PRs that need a code review label Jul 1, 2024
@mneudert mneudert merged commit a391178 into 5.x-dev Jul 2, 2024
35 of 46 checks passed
@mneudert mneudert deleted the dbfeaturetests branch July 2, 2024 18:20
mneudert added a commit that referenced this pull request Sep 13, 2024
@mneudert
Backport test changes from #22356
14d495b
mneudert added a commit that referenced this pull request Sep 13, 2024
@mneudert
Backport test changes from #22356
8996ed1
sgiehl pushed a commit that referenced this pull request Sep 13, 2024
@mneudert
Add configuration for database connection collation (5.1.x) (#22588)
30a811c 
* Define default collation for TiDB tables (#22271)

* Add configuration for database connection collation (#22564)

* Backport test changes from #22356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mneudert mneudert mneudert approved these changes

Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sgiehl @mneudert