Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MTM no data tab translation #22365

Merged
merged 15 commits into from
Jul 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/JsTrackerInstallCheck/JsTrackerInstallCheck.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public function registerEvents()

public function getClientSideTranslationKeys(&$translationKeys)
{
$translationKeys[] = 'JsTrackerInstallCheck_TestInstallationDescription';
$translationKeys[] = 'JsTrackerInstallCheck_OptionalTestInstallationDescription';
$translationKeys[] = 'JsTrackerInstallCheck_TestInstallationBtnText';
$translationKeys[] = 'JsTrackerInstallCheck_JsTrackingCodeInstallCheckSuccessMessage';
$translationKeys[] = 'JsTrackerInstallCheck_JsTrackingCodeInstallCheckFailureMessage';
Expand Down
2 changes: 1 addition & 1 deletion plugins/JsTrackerInstallCheck/lang/en.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"JsTrackerInstallCheck": {
"PluginDescription": "Validate whether the tracking code has been installed on your site and that it can send tracking requests back to your Matomo instance",
"TestInstallationDescription": "To test that the tracking code is able to send requests to your Matomo instance, enter the exact URL you are tracking and click on \"Test installation\". A new tab will open, and should close within 10 seconds.",
"OptionalTestInstallationDescription": "Optional: To test that the tracking code is able to send requests to your Matomo instance, enter the exact URL you are tracking and click on \"Test installation\". A new tab will open, and should close within 10 seconds.",
"TestInstallationBtnText": "Test installation",
"JsTrackingCodeInstallCheckSuccessMessage": "The tracking code is installed successfully! This screen will disappear as soon as some data is tracked for your website.",
"JsTrackingCodeInstallCheckFailureMessage": "Tracking code verification failed. Please verify that you have installed the code correctly. %1$sLearn more%2$s.",
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<span>{{ translate('JsTrackerInstallCheck_TestInstallationDescription') }}</span>
<span>{{ translate('JsTrackerInstallCheck_OptionalTestInstallationDescription') }}</span>
<div class="jsTrackerInstallCheck">
<div class="row testInstallFields">
<div class="col s2">
Expand Down
4 changes: 2 additions & 2 deletions tests/UI/expected-screenshots/EmptySite_detected_osano.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions tests/UI/expected-screenshots/EmptySite_trackingCode.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions tests/UI/expected-screenshots/EmptySite_wordpress.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading