Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes copy code not working for modal due to no focus in Modal #22366

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Fixes copy code not working for modal due to no focus in Modal #22366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions plugins/CoreHome/vue/dist/CoreHome.umd.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion plugins/CoreHome/vue/dist/CoreHome.umd.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions plugins/CoreHome/vue/src/CopyToClipboard/CopyToClipboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ function onClickHandler(pre: HTMLElement) {
textarea.style.left = '-9999px';
document.body.appendChild(textarea);
textarea.select();
textarea.focus();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make more sense to focus first and then select? Just purely from the perspective of what happens when a user selects text in a textarea.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michalkleiner No preference over it as it needs focus just before document.execCommand('copy'); is executed for it to work always, so added there and won't make any harm I believe even if change to what you are suggesting.

document.execCommand('copy');
document.body.removeChild(textarea);
const btn = (pre.parentElement as HTMLButtonElement);
Expand Down