Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invalidation of currently processed archives correctly #22392

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 12, 2024

Description:

When a period is being invalidated for whatever reason, we currently update all existing archives to the state INVALIDATED. Invalidated archives may still be used for reporting until new archives were built.

Updating archives to invalidated currently is also done for archives that are still in progress. In progress archives aren't considered for the reporting. So updating them to invalidated while they are still processed currently has the effect, that unfinished archives might be used for reporting, causing report data to disappear, for reports that were not yet processed for this archive. Once the archiving is finished those archives are updated to OK, causing them to get final again, even if they had been marked as invalidated in between.

This PR fixes the behavior by introducing a new state to mark in progress archives invalidated. This new state won't be considered for reporting, but when the archiving finished, the status will be updated to INVALIDATED instead of OK.

Refs DEV-18289

Review

@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. labels Jul 15, 2024
@sgiehl sgiehl added this to the 5.2.0 milestone Jul 15, 2024
@sgiehl sgiehl marked this pull request as ready for review July 15, 2024 16:03
@sgiehl sgiehl requested a review from a team July 16, 2024 13:12
@sgiehl sgiehl added the Needs Review PRs that need a code review label Jul 16, 2024
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes make sense to me. I've left some minor code suggestions but it'd be ok if not accepted, too.

@sgiehl sgiehl merged commit 67e6025 into 5.x-dev Jul 19, 2024
25 checks passed
@sgiehl sgiehl deleted the inprogressinvalidation branch July 19, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants