-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use invalidations for performing check for intersecting periods being processed #22394
Open
sgiehl
wants to merge
5
commits into
5.x-dev
Choose a base branch
from
fixintersectingcheck
base: 5.x-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+668
−832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
force-pushed
the
fixintersectingcheck
branch
6 times, most recently
from
July 15, 2024 15:22
5022d59
to
9178d93
Compare
sgiehl
added
the
Enhancement
For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
label
Jul 15, 2024
sgiehl
added
the
Major
Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
label
Jul 15, 2024
sgiehl
force-pushed
the
inprogressinvalidation
branch
from
July 16, 2024 13:01
90808ff
to
7806cd6
Compare
sgiehl
force-pushed
the
fixintersectingcheck
branch
from
July 16, 2024 13:09
acb5b40
to
a516546
Compare
michalkleiner
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks ok, but would prefer another pair of 👀 to have a look as well.
caddoo
previously approved these changes
Jul 19, 2024
sgiehl
force-pushed
the
fixintersectingcheck
branch
from
July 19, 2024 10:34
7728544
to
5311faf
Compare
sgiehl
force-pushed
the
fixintersectingcheck
branch
from
July 19, 2024 13:58
5311faf
to
607f032
Compare
michalkleiner
previously approved these changes
Jul 22, 2024
sgiehl
force-pushed
the
fixintersectingcheck
branch
2 times, most recently
from
July 28, 2024 15:56
60902ed
to
7fd600b
Compare
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
github-actions
bot
added
the
Stale
The label used by the Close Stale Issues action
label
Aug 5, 2024
sgiehl
force-pushed
the
fixintersectingcheck
branch
from
August 5, 2024 08:36
7fd600b
to
e1fed6a
Compare
11 tasks
sgiehl
force-pushed
the
fixintersectingcheck
branch
from
August 19, 2024 18:14
d88dcc7
to
f27a0fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Enhancement
For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Major
Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Needs Review
PRs that need a code review
Stale
The label used by the Close Stale Issues action
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When archiving is running, we are basically processing invalidations that were previously created.
To ensure that every processed invalidation already has all required data available, we perform certain checks to avoid that e.g. a week archive is processed when a day archives of that week is still processed. Similar checks are applied for segment processing.
Currently the check for other archiving jobs that might process an invalidation for an intersecting period (or segment) is performed by checking the running multicli processes. This might work fine if a single machine is performing the archiving. But as soon as there are multiple servers performing the archiving, this detection would fail, causing intersecting periods being archived in parallel.
By looking into the invalidation table instead of checking running processes, we can ensure that running jobs are detected across multiple machines.
It though carries the risk of making detection of failed archiving jobs bit worse. We will work on further improvements for this separately.
Refs DEV-18290
Review