Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip invalidating yesterday if a proper archive is already in progress #22400

Merged
merged 5 commits into from
Jul 19, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 16, 2024

Description:

Our archiving process in the beginning automatically invalidates all data for today and yesterday. This is done to ensure those archives are finally built with all data.

For invalidating yesterday there are already certain restrictions when this will be skipped. If there is already an archive available that was built after midnight, it will be skipped as there won't be any new data to include anyway.

This PR extends those checks to also skip the invalidation if another archiving process is already archiving yesterday and was started after midnight. This prevents that this currently built archive can be invalidated right away before it was even finished.

Review

@sgiehl sgiehl added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Stability For issues that make Matomo more stable and reliable to run for sys admins. labels Jul 16, 2024
@sgiehl sgiehl added this to the 5.2.0 milestone Jul 16, 2024
@sgiehl sgiehl force-pushed the skipinvalidationforyesterday branch from ab4ac1f to c231373 Compare July 16, 2024 12:15
@sgiehl sgiehl added the Needs Review PRs that need a code review label Jul 16, 2024
@sgiehl sgiehl requested a review from a team July 16, 2024 12:16
@sgiehl sgiehl force-pushed the skipinvalidationforyesterday branch 2 times, most recently from fba3f1b to ea2f7a8 Compare July 16, 2024 12:57
@sgiehl sgiehl force-pushed the skipinvalidationforyesterday branch from ea2f7a8 to 291abb4 Compare July 16, 2024 13:10
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was contemplating whether the mechanism should moved to invalidateWithSegments but it is probably ok where it is.

@sgiehl sgiehl force-pushed the skipinvalidationforyesterday branch from 86a654a to 234a519 Compare July 19, 2024 14:00
@sgiehl sgiehl changed the base branch from fixintersectingcheck to 5.x-dev July 19, 2024 14:00
@sgiehl sgiehl merged commit b1d6b4c into 5.x-dev Jul 19, 2024
23 of 25 checks passed
@sgiehl sgiehl deleted the skipinvalidationforyesterday branch July 19, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review Stability For issues that make Matomo more stable and reliable to run for sys admins.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants