-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event to alter delete website confirmation #22484
Merged
Merged
Changes from 21 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
f0f1f4b
Adds event to alter delete website explanation, #PG-3574
AltamashShaikh 0273a81
Merge branch '5.x-dev' into PG-3574-delete-website-message-event
AltamashShaikh 5281d4d
Refactor code to getDeleteExplantionText only when deleteAction is tr…
AltamashShaikh c5927a2
Merge branch '5.x-dev' into PG-3574-delete-website-message-event
AltamashShaikh 84ef82f
Ui test updated
AltamashShaikh a71dc60
Merged with 5.x-dev
AltamashShaikh 986af11
Updated UI screenshot
AltamashShaikh 6df4383
Merge branch '5.x-dev' into PG-3574-delete-website-message-event
AltamashShaikh 2b4ebe7
Merged with 5.x-dev
AltamashShaikh 0654b26
Updated UI screenshot
AltamashShaikh 6bb6f7c
Merge branch '5.x-dev' into PG-3574-delete-website-message-event
AltamashShaikh 2bbd371
Apply PR feedback
AltamashShaikh 4d9d66e
Updated UI screenshot
AltamashShaikh 64f7943
Apply PR feedbacks
AltamashShaikh 1bb2940
Merge branch '5.x-dev' into PG-3574-delete-website-message-event
AltamashShaikh 4a789d5
Merge branch '5.x-dev' into PG-3574-delete-website-message-event
AltamashShaikh aad1b5d
Fixes failing tests
AltamashShaikh b307e65
Merge branch 'PG-3574-delete-website-message-event' of github.com:mat…
AltamashShaikh 2750757
Removes TagManager dependent test
AltamashShaikh f8cd678
Changes for even space
AltamashShaikh d4cd09a
Merge branch '5.x-dev' into PG-3574-delete-website-message-event
michalkleiner 03f6cb2
Applied PR feedback
AltamashShaikh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a comment above the event to document what it is good for. Like it'S e.g. the case here:
matomo/core/Scheduler/Scheduler.php
Lines 157 to 166 in 9a3ef94
And when looking at other events it seems we use to pass the referenced parameter first, and then the other. So you may switch
idSite
andmessages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sgiehl Added as suggested 👍