Fix archiving for range periods #22577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
sgiehl
force-pushed
the
fixrangearchiving
branch
from
64ea614
to
32d7883
Compare
sgiehl
force-pushed
the
fixrangearchiving
branch
from
e77bd7f
to
ab0d8b0
Compare
michalkleiner
approved these changes
Sep 12, 2024
jorgeuos
pushed a commit
to jorgeuos/matomo
that referenced
this pull request
Oct 1, 2024
* Fix archiving for range periods * adds another test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
with #22519 we have improve some checks around skipping invalidations / archiving for todays segments. Adjusting such check caused another bug to show up. The bug already existed before but only came to fruition with the changes lately.
Review