Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve database collation detection (5.1.x) #22595

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Improve database collation detection (5.1.x) #22595

merged 1 commit into from
Sep 25, 2024

Conversation

mneudert
Copy link
Member

Description:

Cherry picks #22594 for patch release.

Review

@mneudert mneudert added this to the 5.1.2 milestone Sep 17, 2024
michalkleiner
michalkleiner approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local testing updating from 5.1.0 to this PR worked as expected.

@michalkleiner michalkleiner marked this pull request as ready for review September 25, 2024 16:09
@mneudert mneudert added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review Stability For issues that make Matomo more stable and reliable to run for sys admins. labels Sep 25, 2024
@michalkleiner michalkleiner merged commit 4fa47af into 5.1.x-dev Sep 25, 2024
20 of 25 checks passed
@michalkleiner michalkleiner deleted the improve-collation-detection-51 branch September 25, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Stability For issues that make Matomo more stable and reliable to run for sys admins.
Projects
None yet
Milestone
5.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@mneudert @michalkleiner