Add drag and drop for selected reports #23913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… testing the order persistence of selected reports
…cheduled reports as well as updated reports. Old reports should retain the old order
…stence of selected reports, we are also testing creating and updating a scheduled report
… adding enforceOrder parameter to Integration tests
…fault or if it is not passed as part of the parameter when adding or updating the scheduled report.
…ame function as the rest of the report parameters
chippison
force-pushed
the
add-drag-and-drop-for-selected-reports
branch
from
bd05c89 to
51bc2ee
Compare
…gory if 'enforceOrder' parameter is false
nathangavin
previously approved these changes
Jan 5, 2026
Contributor
nathangavin
left a comment
nathangavin
left a comment
There was a problem hiding this comment.
Looks good to me, only minor issue is perhaps some leftover code? see comment.
nathangavin
approved these changes
Jan 7, 2026
sgiehl
reviewed
Jan 12, 2026
| const $list = jq('.selectedReportsList'); | ||
| // Get sortable instance and call stop handler manually, | ||
| // so that we simulate the emitted reorder event | ||
| const stopHandler = $list.sortable('option', 'stop'); |
Member
There was a problem hiding this comment.
We should avoid using jQuery UI where possible. The short / mid term plan is to fully remove it, not to add more usage of it. See #16033
Contributor
Author
There was a problem hiding this comment.
Thanks for the info on this @sgiehl.
I'll not add in new jquery code in the future
Contributor
There was a problem hiding this comment.
Interesting info.
It's noted on my side too! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UX-352
We want to be able to add a new section that shows the 'selected reports' and be able to re-order them.
We would want the reports to be created/displayed in the order they where put in.
fixes #17662
Acceptance Criteria:
Checklist
Review