Skip to content

Make improvements to PDF reports #23919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chippison wants to merge 21 commits into
base: 5.x-dev
Choose a base branch
from
+521 −70
Open

Make improvements to PDF reports #23919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
6fc4416
force portrait on all pdf reports
chippison Dec 23, 2025
f2d1918
making the first column a bit smaller and making the text wrap
chippison Dec 24, 2025
3606b53
making the column labels position be computed dynamically based on it…
chippison Dec 24, 2025
29a8104
adding functionality to adjust label width and padding depending on t…
chippison Dec 28, 2025
5069961
remove checks for orientation portrait. we now assume PDF's are alway…
chippison Dec 28, 2025
788e5bd
adjusting columns based on max width for revenue column. We want to m…
chippison Dec 28, 2025
20a43d4
making label row height be more dynamic and making the rendering of l…
chippison Dec 29, 2025
e6c606d
making all tables use full width of the report
chippison Dec 29, 2025
cdd1e66
making report table headers be closer to the table.
chippison Dec 29, 2025
a58c0d2
refactoring function paintReportTableHeader into smaller functions so…
chippison Dec 29, 2025
39b2531
making sure we adjust the width for ecommerce revenue as well
chippison Dec 30, 2025
53993f7
updated tests. this will now also test our changes that pdf reports a…
chippison Dec 30, 2025
cdab9db
removed unused variable
chippison Dec 30, 2025
d356021
adding new pdf for system test
chippison Dec 30, 2025
5f61338
adding check to see if label text is a url, if true, we should format…
chippison Dec 31, 2025
91e47a1
making cosmetic changes to header. making it bold and moving it up a …
chippison Dec 31, 2025
af2ee3a
updating expected pdfs with our new changes
chippison Dec 31, 2025
d6bf891
fix some phpcs issues
chippison Dec 31, 2025
50d4354
adding comments
chippison Jan 4, 2026
0ac4127
making changes based on review
chippison Jan 6, 2026
8d99fef
making the third line padding an attribute of the class
chippison Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading