Admin users don't see all users but can now "Give an existing user view access" by entering the username #9379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
| */ | ||
| public function checkUserHasSomeAdminAccess() | ||
| public function isUserHasSomeAdminAccess() |
There was a problem hiding this comment.
I added it to this class for easier injecting of dependencies and easier testing. Added tests for this method... this is what we should use in the future anyway instead of Piwik::check... or Piwik::is...
Revert "Fixes visitor map height calculation bug"
mattab
pushed a commit
that referenced
this pull request
Dec 21, 2015
Don't let "admin" users see all other users in Piwik
|
I couldn't find anything to feedback, this is a wonderful PR! and 👍 all the new test cases! |
mattab
added
Major
mattab
changed the title
mattab
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4314
I didn't name it "Invite user" since this would imply that the user has to confirm/approve the invitation. Therefore named it "Give view access".
In the user manager, for a user having admin access, we show only users that have view or admin access to the selected site. If all sites are selected, we show all users the current user is allowed to see.