Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed GA3 sunset note and added no hits note for Cloud, #PG-3912 #558

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Removed GA3 sunset note and added no hits note for Cloud, #PG-3912 #558

merged 4 commits into from
Dec 11, 2024

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Removed GA3 sunset note and added no hits note for Cloud
Fixes: #PG-3912

Review

snake14
snake14 reviewed Dec 10, 2024
View reviewed changes
snake14
snake14 reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just had the one question about the wording of the new note.

I'm guessing that we'll likely have to update the ConnectAccounts UI screenshots?

@AltamashShaikh
Copy link
Contributor Author

@snake14 Yes will re run the tests for ConnectAccounts after merging this

@AltamashShaikh AltamashShaikh merged commit 06460ba into 5.x-dev Dec 11, 2024
6 checks passed
@AltamashShaikh AltamashShaikh deleted the PG-3912-remove-ga3-sunset-note branch December 11, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snake14 snake14 snake14 left review comments

@gillnd gillnd gillnd left review comments

Assignees
No one assigned
Labels
Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AltamashShaikh @snake14 @gillnd