Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes lower case logic to DB, #PG-4087, #174 #175

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Changes lower case logic to DB, #PG-4087, #174 #175

merged 3 commits into from
Jan 15, 2025

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Changes lower case logic to DB
Fixes: #PG-4087, #174

Review

snake14
snake14 approved these changes Jan 12, 2025
View reviewed changes
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I confirmed that the case changed based on the system setting when I invalidated and re-archived 👍

snake14
snake14 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea using the event! It appears to work as expected during functional testing 👍

@AltamashShaikh AltamashShaikh merged commit 0c3df01 into 5.x-dev Jan 15, 2025
6 checks passed
@AltamashShaikh AltamashShaikh deleted the PG-4087-fix-retain-case-logic branch January 15, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snake14 snake14 snake14 approved these changes

@sgiehl sgiehl Awaiting requested review from sgiehl

Assignees
No one assigned
Labels
Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AltamashShaikh @snake14