Improves Slack ChannelID validation to allow only alphanumeric values #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snake14
approved these changes
Sep 24, 2025
Contributor
snake14
left a comment
snake14
left a comment
There was a problem hiding this comment.
Looks good! 👍
I left one question.
| } elseif (empty($parameters[self::SLACK_CHANNEL_ID_PARAMETER])) { | ||
| throw new \Exception(Piwik::translate('Slack_SlackChannelIdRequiredErrorMessage')); | ||
| } | ||
| $slackChannels = explode(',', (string) $parameters[self::SLACK_CHANNEL_ID_PARAMETER]); |
Contributor
There was a problem hiding this comment.
Shouldn't this just use the validateCustomAlertReportParameters method? It's a little confusing that this appears to allow multiple channel IDs while validateCustomAlertReportParameters doesn't.
Contributor
Author
There was a problem hiding this comment.
@snake14 Files can be shared to multiple channelIDs by specifying comma separated values, but this does not work for sending a text message for Slack, hence we have 2 different checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves Slack ChannelID validation to allow only alphanumeric values
Issue No
QA found out that non-alphanumeric characters can be part of SlackChannelID values. PR aims to add a validation rule to allow only alphanumeric values
Steps to Replicate the Issue
Checklist