Skip to content

fix tests [no_release] #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AltamashShaikh merged 1 commit into from
Nov 25, 2025
Merged

fix tests [no_release] #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions tests/Integration/CustomAlertsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,9 @@ public function setUp(): void
}
public function testGetReportMediumOptions()
{
$this->assertEquals([
['key' => 'email', 'value' => 'CustomAlerts_MediumEmail', 'disabled' => false],
['key' => 'mobile', 'value' => 'CustomAlerts_MediumMobile', 'disabled' => false],
$this->assertContains(
['key' => 'slack', 'value' => 'CustomAlerts_MediumSlack', 'disabled' => false],
], CustomAlerts::getReportMediumOptions());
CustomAlerts::getReportMediumOptions()
);
}
}
Binary file modified tests/UI/expected-ui-screenshots/CustomAlerts_send_via_slack_new.png
View file
Open in desktop
Copy link

@tzi tzi Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@james-hill-matomo This screenshot diff is strange, and not related to our last UI changes

Copy link
Contributor Author

@james-hill-matomo james-hill-matomo Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tzi The new option is expected. The extra empty checkbox is annoying, and I've captured it in another ticket.

Copy link
Contributor Author

@james-hill-matomo james-hill-matomo Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://innocraft.atlassian.net/browse/PG-4806

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.