Skip to content

Conversation

@AltamashShaikh
Copy link
Contributor

Description

Improves helptext, adds FAQ link

Issue No

#PG-4519

Steps to Replicate the Issue

  1. Go to SystemSetting and view the helptext for Slack Oauth token
  2. Create/Edit a Scheduled Report and view the Slack Channel helptext.

Checklist

  • [✔] Tested locally or on demo2/demo3?
  • [✔] New test case added/updated?
  • [✔] Are all newly added texts included via translation?
  • [✔] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [NA] Version bumped?

@AltamashShaikh AltamashShaikh added the Needs Review For pull requests that need a code review. label Sep 8, 2025
@AltamashShaikh AltamashShaikh requested a review from a team September 8, 2025 08:37
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good 👍

I just had a couple of questions.

Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in the code and when I view it in my local Matomo instance. 👍

@AltamashShaikh AltamashShaikh merged commit 0d29f39 into 5.x-dev Sep 10, 2025
22 checks passed
@AltamashShaikh AltamashShaikh deleted the PG-4519-improve-helptext branch September 10, 2025 03:28
@AltamashShaikh AltamashShaikh restored the PG-4519-improve-helptext branch September 17, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review For pull requests that need a code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants