-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add copy button in install code screen, #PG-3520 #814
Conversation
I added a test for Clipboard copy, but facing same as what we are facing in CrashAnalytics so removed the test. |
@AltamashShaikh Weren't the changes in matomo-org/matomo#22332 meant for making that possible? |
@sgiehl If you checkout this PR and click Install Code under TagManager menu and try to copy the MTM code by clicking copy button, it will not copy anything. On debugging I found out that we need to set focus to allow it to copy. So the changes in matomo-org/matomo#22366 adds only the focus to make copy work in modal. Puppeter issue is different. |
@sgiehl Sadly, matomo-org/matomo#22332 didn't solve the Puppeteer issue as I had hoped, either. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Once I pulled the latest version of core, the button copied the code snippet to my clipboard as expected 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, works well once I pull core code. Good issue to fix, nice one 👍
Description:
Add copy button in install code screen
Fixes: #812 & #PG-3520
Require: matomo-org/matomo#22366
Review