-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds code to update delete site explanation when a site has MTM container, #PG-3574 #846
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests/UI/expected-screenshots/TagManager_manageWebsitesDeleteAction.png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality works as expected. It even gracefully handles edge case of 100 containers in the "will be deleted" list. Overall implementation looks good 👍
@snake14 Did anything changed in SitesManager plugin after vue:build?
|
@AltamashShaikh I don't see any change in SitesManager, so it must have just forced the cache even though I already tried clearing the cache via console command 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and functional testing worked as expected 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Confirmed that the message displays as expected while deleting a site from my local instance 👍
@snake14 Core PR is merged, can you review the PR once again ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I updated to the latest version of Core and this branch. Everything displayed as expected 👍
Description:
Adds code to update delete site explanation when a site has MTM container
Requires: matomo-org/matomo#22484
Fixes: #PG-3574
Review