do not use impl AsRef in convert_to_pybytes

matrix-nio · Sep 13, 2024 · dc14d6d · dc14d6d
1 parent 1977bde
commit dc14d6d
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/src/account.rs b/src/account.rs
@@ -140,7 +140,7 @@ impl Account {
             Session {
                 inner: result.session,
             },
-            convert_to_pybytes(result.plaintext),
+            convert_to_pybytes(result.plaintext.as_slice()),
         ))
     }
 }
diff --git a/src/lib.rs b/src/lib.rs
@@ -59,6 +59,6 @@ fn my_module(py: Python<'_>, m: &Bound<'_, PyModule>) -> PyResult<()> {
     Ok(())
 }
 
-pub(crate) fn convert_to_pybytes(bytes: impl AsRef<[u8]>) -> Py<PyBytes> {
-    Python::with_gil(|py| PyBytes::new_bound(py, bytes.as_ref()).into())
+pub(crate) fn convert_to_pybytes(bytes: &[u8]) -> Py<PyBytes> {
+    Python::with_gil(|py| PyBytes::new_bound(py, bytes).into())
 }
diff --git a/src/session.rs b/src/session.rs
@@ -66,6 +66,8 @@ impl Session {
     }
 
     fn decrypt(&mut self, message: &AnyOlmMessage) -> Result<Py<PyBytes>, SessionError> {
-        Ok(convert_to_pybytes(self.inner.decrypt(&message.inner)?))
+        Ok(convert_to_pybytes(
+            self.inner.decrypt(&message.inner)?.as_slice(),
+        ))
     }
 }
diff --git a/src/types/messages.rs b/src/types/messages.rs
@@ -48,7 +48,7 @@ impl AnyOlmMessage {
 
     pub fn to_parts(&self) -> (usize, Py<PyBytes>) {
         let (message_type, ciphertext) = self.inner.clone().to_parts();
-        (message_type, convert_to_pybytes(ciphertext))
+        (message_type, convert_to_pybytes(ciphertext.as_slice()))
     }
 }