Add Python Attribute Accessors and Cross-Library Compatibility for PkEncryption #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing Python attribute accessors and improves compatibility with python-olm by enabling cross-library encryption and decryption tests.
Details:
#[pyo3(get)]
annotations to theMessage
struct fields (ciphertext
,mac
,ephemeral_key
), making these attributes accessible from Python.Message
constructor in Rust (via#[new]
), allowing Python code to createMessage
instances directly.PkEncryption
is compatible with python-olm. Specifically:Next Steps:
To achieve seamless compatibility, the user will need to Base64-encode Vodozemac message attributes (ciphertext, mac, ephemeral_key) before passing them to Olm. For example:
A future enhancement could add a Rust helper function to handle this encoding automatically, such as:
Also
unpad_base64_encode
andpad_base64_decode
functions.This would streamline the process and reduce the amount of Python-side encoding logic required.