Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PkEncryption support #4

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Conversation

MatMaul
Copy link
Contributor

@MatMaul MatMaul commented Sep 4, 2024

Currently a draft since it relies on #8 and a new vodozemac release.

src/pk_encryption.rs Outdated Show resolved Hide resolved
src/pk_encryption.rs Outdated Show resolved Hide resolved
src/pk_encryption.rs Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
src/pk_encryption.rs Outdated Show resolved Hide resolved
@MatMaul MatMaul requested a review from poljar September 5, 2024 08:21
@poljar
Copy link
Collaborator

poljar commented Sep 12, 2024

Let's undraft this, we can depend on a git rev of vodozemac for a bit before I do the release.

@MatMaul
Copy link
Contributor Author

MatMaul commented Sep 12, 2024

As a first I've undraft #8 and pin the last git revision of vodozemac.

@poljar
Copy link
Collaborator

poljar commented Sep 17, 2024

Can this be undrafted now as well?

@MatMaul MatMaul marked this pull request as ready for review September 17, 2024 13:24
@MatMaul
Copy link
Contributor Author

MatMaul commented Sep 17, 2024

I rebased on main and undrafted.

Copy link
Collaborator

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of nits, and clippy needs to be convinced as well.

src/types/curve25519.rs Outdated Show resolved Hide resolved
src/error.rs Show resolved Hide resolved
src/types/curve25519.rs Show resolved Hide resolved
@MatMaul MatMaul requested a review from poljar September 17, 2024 14:43
@poljar poljar merged commit 9034bbd into matrix-nio:main Sep 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants