Add PkEncryption support#4
Merged
poljar merged 3 commits intomatrix-nio:mainfrom Sep 18, 2024
Merged
Conversation
poljar
requested changes
Sep 4, 2024
MatMaul
commented
Sep 5, 2024
MatMaul
force-pushed
the
add-pk-encryption
branch
from
015fcc6 to
b3b9295
Compare
Collaborator
|
Let's undraft this, we can depend on a git rev of vodozemac for a bit before I do the release. |
Contributor
Author
|
As a first I've undraft #8 and pin the last git revision of vodozemac. |
Collaborator
|
Can this be undrafted now as well? |
MatMaul
force-pushed
the
add-pk-encryption
branch
from
b3b9295 to
697b606
Compare
MatMaul
force-pushed
the
add-pk-encryption
branch
from
697b606 to
288148d
Compare
Contributor
Author
|
I rebased on main and undrafted. |
poljar
requested changes
Sep 17, 2024
Collaborator
poljar
left a comment
poljar
left a comment
There was a problem hiding this comment.
Left a couple of nits, and clippy needs to be convinced as well.
poljar
approved these changes
Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently a draft since it relies on #8 and a new vodozemac release.