This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Respect rate limits by not continuing to send if 429 received. #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulir
reviewed
Mar 4, 2021
Co-authored-by: Tulir Asokan <[email protected]>
|
CI is failing and it would be nice to add a test to |
|
Happy for someone to take this on, very much don't wait for me - i just want it not to chew CPU cycles on matrix.org with 429 errors. I might find some time in a few months to learn enough go, as it seems the library upgrade wasn't as simple as advertised. |
|
I'll see if I can get to this this week. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm aware this will drop messages on the floor - but given we do not retry these messages that are returning 429 errors anyway, there's little point in continuing to retry and it only adds load to the live server.