Merge pull request #408 from matrix-org/hs/no-update-botid-userid

Ensure user's profile is not modified when they delete a bot
matrix-org · May 11, 2020 · 7a56c1b · 7a56c1b
2 parents 27c7c0a + 1be593d
commit 7a56c1b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/changelog.d/408.bugfix b/changelog.d/408.bugfix
@@ -0,0 +1 @@
+Bridge will no longer update user's displayname with a bots name when a bot is modified
diff --git a/src/SlackGhost.ts b/src/SlackGhost.ts
@@ -155,7 +155,11 @@ export class SlackGhost {
         let displayName = message.username || message.user_name;
 
         if (room.SlackClient) { // We can be smarter if we have the bot.
-            if (message.bot_id) {
+            if (message.bot_id && message.user_id) {
+                // In the case of operations on bots, we will have both a bot_id and a user_id.
+                // Ignore updating the displayname in this case.
+                return;
+            } else if (message.bot_id) {
                 displayName = await this.getBotName(message.bot_id, room.SlackClient);
             } else if (message.user_id) {
                 displayName = await this.getDisplayname(room.SlackClient);
@@ -245,7 +249,11 @@ export class SlackGhost {
         }
         let avatarUrl;
         let hash: string|undefined;
-        if (message.bot_id) {
+        if (message.bot_id && message.user_id) {
+            // In the case of operations on bots, we will have both a bot_id and a user_id.
+            // Ignore updating the displayname in this case.
+            return;
+        } else if (message.bot_id) {
             avatarUrl = await this.getBotAvatarUrl(message.bot_id, room.SlackClient);
             hash = avatarUrl;
         } else if (message.user_id) {
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Bridge will no longer update user's displayname with a bots name when a bot is modified