Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Support custom Slack emoji #500

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

WIP: Support custom Slack emoji #500

wants to merge 15 commits into from

Conversation

jaller94
Copy link
Contributor

Resolves #497.

@Cadair
Copy link
Collaborator

Cadair commented Sep 23, 2020

We should follow matrix-org/matrix-spec-proposals#2545 and implement this, then at least fluffychat and revolution will be able to send these as well?

@jaller94 jaller94 changed the title WIP: Support custom Slack emojis WIP: Support custom Slack emoji Sep 23, 2020
@jaller94
Copy link
Contributor Author

Adding the custom emoji to Matrix sounds like a V2 feature at this point.

@Cadair
Copy link
Collaborator

Cadair commented Sep 23, 2020

Sounds like something I might be willing to take a swing at 😄

@jaller94
Copy link
Contributor Author

I am running into this issue

code: 'slack_webapi_platform_error',
  data: {
    ok: false,
    error: 'missing_scope',
    needed: 'emoji:read',
    provided: 'identify,bot:basic',
    response_metadata: { scopes: [Array], acceptedScopes: [Array] }
  }

The official docs for emoji.list say:

Bots belonging to Slack apps are not supported
This method cannot be called with bot user tokens belonging to Slack apps, although legacy bot tokens will work. To use this method in a Slack app, use a user token imbued with the necessary scope. Stay tuned for updates as we bring a fuller feast of features to bots belonging to Slack apps.

@Half-Shot
Copy link
Contributor

I am running into this issue

This is surprising. We use classic bot tokens (NOT bot user tokens) which apparently work with https://api.slack.com/methods/emoji.list

// }
log.info(`Syncing custom emoji ${teamId}`);

const response = await client.emoji.list();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually create a response type interface because the client sucks and doesn't return any types.

@AndrewFerr AndrewFerr requested a review from a team as a code owner November 15, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom Slack emoji
3 participants