Improve plaintext formatting of Matrix messages sent via webhooks #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tadeusz „tadzik” Sośnierz <[email protected]>
Signed-off-by: Tadeusz „tadzik” Sośnierz <[email protected]>
In webhook mode sending messages comes with some limitations, including us not being able to impersonate users or upload attachements. This makes us fallback to plaintext relaybot behaviour, while preserving as much from the original message as possible. Signed-off-by: Tadeusz „tadzik” Sośnierz <[email protected]>
Half-Shot
requested changes
Apr 16, 2024
| @@ -234,6 +234,16 @@ export class SlackHookHandler extends BaseSlackHandler { | |||
| return; | |||
| } | |||
|
|
|||
| if (params.token !== room.SlackWebhookToken) { | |||
There was a problem hiding this comment.
Do we permit it if no room.SlackWebhookToken exists?
There was a problem hiding this comment.
Is there any situation when this could be true for webhook-bridged rooms? I don't think the bridge will allow you to set them up that way.
Half-Shot
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In webhook mode sending messages comes with some limitations,
including us not being able to impersonate users or upload attachements.
This makes us fallback to plaintext relaybot behaviour,
while preserving as much from the original message as possible.
Signed-off-by: Tadeusz „tadzik” Sośnierz [email protected]
Depends on: #776