User correct Matrix accounts when redacting events #780
Conversation
This makes us the original sender's intent to redact messages, so that we do not require an elevated PL to handle message deletion.
| @@ -50,6 +50,7 @@ export interface ISlackEventMessageAttachment { | |||
| } | |||
|
|
|||
| export interface ISlackMessageEvent extends ISlackEvent { | |||
| team?: string; | |||
There was a problem hiding this comment.
I have not actually seen team_id in incoming Slack messages, and the only place I see it used is when it's artificially assigned to in SlackRTMHandler – perhaps it's an error in our typing?
There was a problem hiding this comment.
I don't really remember when this was introduced, it's possible it's invalid and team_id is the right one.
src/SlackEventHandler.ts
Outdated
| } | ||
| else { | ||
| const ghost = await this.main.ghostStore.get(previousMessage.user, previousMessage.team_domain, previousMessage.team); | ||
| await ghost.redactEvent(originalEvent.roomId, originalEvent.eventId); |
There was a problem hiding this comment.
Should we try with the botClient if this fails, as a fallback?
src/SlackEventHandler.ts
Outdated
| } | ||
| } | ||
| else if (!previousMessage.user) { | ||
| log.error("Cannot redact Slack message if we don't know the original sender:", previousMessage); |
There was a problem hiding this comment.
can we just use the botClient?
There was a problem hiding this comment.
Done in b4f2911; this has a side effect of us trying to delete messages sent by originally-Matrix users with the slack bot – which probably makes sense.
| @@ -50,6 +50,7 @@ export interface ISlackEventMessageAttachment { | |||
| } | |||
|
|
|||
| export interface ISlackMessageEvent extends ISlackEvent { | |||
| team?: string; | |||
There was a problem hiding this comment.
I don't really remember when this was introduced, it's possible it's invalid and team_id is the right one.
…rmine a more fitting user
Added in e2df892 |
Fixes #766
For events sent from Slack and later deleted from Slack, we use the same Slack Ghost that sent the message – this alleviates the need for an elevated Power Level.
For events sent from Matrix and deleted from Slack, we try to use our bot account. This does require us to have a sufficient power level, so we try to be helpful in the logs if we don't.
Note: Slack doesn't tell us who deleted the message, so we can't bridge that precisely – the sender of a redact event is just our best effort.