This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Add rate-limiting for account recovery and registration #3093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoiding name clash between IP address and e-mail address
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
fcf68f6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://452668df.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://rei-rl-registration.matrix-authentication-service-docs.pages.dev |
sandhose
reviewed
Aug 7, 2024
| @@ -130,14 +132,25 @@ pub(crate) async fn post( | |||
| // Verify the CSRF token | |||
| let () = cookie_jar.verify_form(&clock, form)?; | |||
|
|
|||
| // Check the rate limit if we are about to process the form | |||
| if let Err(e) = limiter.check_account_recovery(requester, &recovery_session.email) { | |||
| tracing::warn!(error = &e as &dyn std::error::Error); | |||
There was a problem hiding this comment.
I really wish tracing had a sigil (like ? or %) to report as &dyn Error :(
There was a problem hiding this comment.
you're not alone: tokio-rs/tracing#1308
Co-authored-by: Quentin Gliech <[email protected]>
sandhose
approved these changes
Aug 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #3090
Fixes #2992
Fixes #2541