Add bridge port to Pod and Service manifests in Helm Chart #802
Conversation
| @@ -48,6 +48,9 @@ containers: | |||
| mountPath: "/data" | |||
| {{- end }} | |||
| ports: | |||
| - name: bridge | |||
| containerPort: {{ .Values.hookshot.config.bridge.port }} | |||
There was a problem hiding this comment.
Heya, do you know what the bridge port corresponds to. This isn't the appservice (below)?
There was a problem hiding this comment.
Originally I thouth so, but I'm not sure, TBH. There is a port 9993 defined in the bridge configuration section. But in the service and container definitions are used hardcoded ports which does not correspond with bridge port. 🤷♂️
There was a problem hiding this comment.
So I've been digging more and the ports are really different. The appservice here is probably serving widget stuff, but the bridge itself is running on port defined in .Values.hookshot.config.bridge.port. Therefore, there must be another service for it.
Here is what ports are actually listening in the container:
And Here in the values.yaml, there is appservice as listener.
So I think this PR is legit. 🤔 At least I couldn't make the hookshot work without these changes.
There was a problem hiding this comment.
Hey, It's been a while. Did you manage to get into this? I want to use the Helm chart installation, but I cannot, since the bridge port is not propagated on Pod or even available in the Service.
If I am doing something wrong, I would like to know what 🤷♂️
Thanks
There was a problem hiding this comment.
Yes, can this please merged? We need to have Port 9993 opened in the cluster, so that we can reach it with the registration of synapse. Otherweise the helm chart ist useless.
Signed-off-by: Hy3n4 <[email protected]>
Hy3n4
force-pushed
the
hookshot_bridge_port
branch
from
bf9bd96
to
9c85b0c
Compare
Hey there 👋 ,
I had this fight with the Hookshot installed via Helm Chart and this is the result. More info in matrix thread here
I hope I did not forgot anything and this PR is valid.