Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore createKeyWithKeyId #1885

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Oct 23, 2024

No description provided.

}
else
{
OLMPkDecryption *decryption = [OLMPkDecryption new];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This uses OLMKit

Copy link
Member

@BillCarsonFr BillCarsonFr Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This uses OLMKit

I think it's just generating 32 random bytes, you can replace with SecRandomCopyBytes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BillCarsonFr okay I think I have replaced it correctly, let me know if this is fine and we can merge it

@Velin92 Velin92 changed the title Restore createKeyWithId Restore createKeyWithKeyId Oct 23, 2024
@Velin92 Velin92 marked this pull request as ready for review November 14, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants