Skip to content

do not set cache in authenticated fetch #5020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

do not set cache in authenticated fetch #5020

wants to merge 5 commits into from
+8 −1

Conversation

pkuzco
Copy link
Contributor

@pkuzco pkuzco commented Sep 27, 2025 •
edited by t3chguy
Loading

Fixes #5019

In practice, there is no need to set the cache property in fetch(), but this PR removes it only when the Authorization header is present.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@pkuzco pkuzco requested a review from a team as a code owner September 27, 2025 17:38
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Sep 27, 2025
@pkuzco pkuzco mentioned this pull request Sep 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from matrix-org/element-web-reviewers

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from matrix-org/element-web-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-cache option prevents preflight requests from being cached
1 participant
@pkuzco