fix(indexeddb): Fix implementation of SafeEncode for tuple of 5 elements#1490
fix(indexeddb): Fix implementation of SafeEncode for tuple of 5 elements#1490jplatte merged 2 commits intomatrix-org:mainfrom
Conversation
Codecov ReportBase: 72.81% // Head: 74.39% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1490 +/- ##
==========================================
+ Coverage 72.81% 74.39% +1.58%
==========================================
Files 121 124 +3
Lines 13300 13726 +426
==========================================
+ Hits 9684 10212 +528
+ Misses 3616 3514 -102
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Now you're running into #1489 😅 Maybe we should add some |
|
But at least it's not my fault 😛 .
Either that or we pin the rust-nightly version? |
|
… or we just wait for rust-lang/rust-clippy#10321 before we merge. If it's merged today, that should be fine 😄 |
|
If you want to sort this out now, I think I'd prefer the attributes because they're more obvious and we still get clippy upgrades even if it takes long for the attributes to be removed again. |
|
It's fine, I'll wait until we're tired of waiting 😁 |
Triggers false positives. See discussion in rust-lang/rust-clippy#10319. Possibly fixed in rust-lang/rust-clippy#10321. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Regression introduced by merging commit 9707d73 after efdeba7.
Fixes #1489.
Signed-off-by: Kévin Commaille zecakeh@tedomum.fr